Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove pagemacro from BiquadFilterNode #4668

Merged
merged 1 commit into from
May 5, 2021
Merged

Remove pagemacro from BiquadFilterNode #4668

merged 1 commit into from
May 5, 2021

Conversation

hamishwillee
Copy link
Collaborator

@hamishwillee hamishwillee commented May 3, 2021 •
edited
Loading

This is part of addressing #3196 (removing pagemacro). More or less same approach as in #4401

Following this fix BiquadFilterNode links to example in BaseAudioContext.createBiquadFilter() rather than importing it.

@hamishwillee hamishwillee requested a review from a team as a code owner May 3, 2021 08:46
@hamishwillee hamishwillee requested review from sideshowbarker and removed request for a team May 3, 2021 08:46
@github-actions
Copy link
Contributor

github-actions bot commented May 3, 2021

Preview URLs

Flaws

URL: /en-US/docs/Web/API/BiquadFilterNode
Title: BiquadFilterNode
on GitHub
Flaw count: 1

  • macros:
    • /en-us/docs/web/api/audionodepassthrough (url: /en-US/docs/Web/API/AudioNodePassThrough) does not exist

External URLs

URL: /en-US/docs/Web/API/BiquadFilterNode
Title: BiquadFilterNode
on GitHub

@sideshowbarker sideshowbarker merged commit feaf6c1 into mdn:main May 5, 2021
@hamishwillee hamishwillee deleted the biquadfilter branch May 5, 2021 07:55
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 14, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sideshowbarker sideshowbarker sideshowbarker approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hamishwillee @sideshowbarker